-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@sveltejs/package: Assume no svelte 3 if can't read version with semver (pnpm calalog) #13553
base: main
Are you sure you want to change the base?
Conversation
|
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
I'm using
pnpm
and thecatalog
feature.It's nice in monorepos to manage deps & version in one place. (+ you can name & group deps)
In
package.json
:An in
pnpm-workspace.yaml
BUT, it's not
semver
standard. :( (Maybe one day?)That's why I would suggest this fix ?
Feel free to le me know what do you think
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits