Skip to content

fix: correctly deserialize on the server #13686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 4, 2025
Merged

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Apr 7, 2025

fixes #13675

This PR adds an optional chain for when deserialize tries to access app.decoders since app is always undefined on the server and is only initialised on the client.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: f9b2bd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@dummdidumm
Copy link
Member

While this works, I'm wondering if this could introduce inconsistencies since you might expect that the decoders you defined will be used, but on the server they don't exist, i.e. will be ignored.

@eltigerchino eltigerchino marked this pull request as draft June 4, 2025 07:20
@eltigerchino eltigerchino marked this pull request as ready for review June 4, 2025 08:43
@eltigerchino
Copy link
Member Author

I've updated deserialize to use the decoders defined by the user on the server too.

@eltigerchino eltigerchino marked this pull request as draft June 4, 2025 08:49
@eltigerchino eltigerchino marked this pull request as ready for review June 4, 2025 08:53
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dummdidumm dummdidumm merged commit c6cd8c3 into main Jun 4, 2025
18 checks passed
@dummdidumm dummdidumm deleted the fix-deserialize-server branch June 4, 2025 09:44
@github-actions github-actions bot mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce of custom transports leads to deserialize not working on server side
2 participants