-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert more adapter files to TypeScript #138
Conversation
index.d.ts | ||
server.js | ||
server.d.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update .prettierignore
at the root of the monorepo accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither of these files actually have any exports so I think we could just skip typings here (see #139)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
input: 'src/index.ts', | ||
output: { | ||
file: 'index.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's confusing that this index.js
is built from TS whereas the one in adapter-netlify
isn't. could we convert the netlifly one to TS too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that we should convert adapter-netlify
. I'm waiting for a new release of tiny-glob
before converting it though (#136 (comment))
Note that there's a couple of build errors due to mismatch with types from e.g. |
2c475f4
to
33f527e
Compare
33f527e
to
9b0e15f
Compare
I've rebased against |
I'm going to go ahead and merge this to unblock my other work, but feel free to leave more comments if you have additional feedback and I'll fix in a follow up |
Makes more progress on #136