generate etags for binary responses #1381
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1136. seeing some test failures that I can't explain so I'm not going to merge this, instead I'm going to reimplement it more carefully. Just leaving this here for reference.
it involves a few changes:
ServerResponse
from the newEndpointOutput
type (both types are public)ServerResponse
body can bestring
orUint8Array
(the latter only/always whencontent-type
isapplication/octet-stream
)EndpointOutput
body can also be aJSONValue
handle
response must beServerResponse
(i.e.body
must bestring
orUint8Array
here, notJSONValue
)rawBody
can bestring
orUint8Array
(less sure about this bit)Aside: brilliantly, in Node, when you call
res.end(uint8Array)
you get the following error:Slow clap. It turns out you can do
res.write(uint8Array), res.end()
though.Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
Changesets
pnpx changeset
and following the prompts