Skip to content

feat: allow the rendering of relative paths #13812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

steamer2k
Copy link

@steamer2k steamer2k commented May 22, 2025

resolves #595
resolves #9569

Allows building SPA sites with a relative asset path.

E.g., whether server from:

  • https://some.server/foo
  • https://some.server/foo/bar
  • https://some.server/foo/bar/baz

...the SPA should be able to find the _app/ subdirectory as a sibling to the fallback page. E.g., given a fallback page of index.html:

someDirectory/
  index.html
  _app/
    immutable/
      assets/...
      chunks/...
      entry/...
      nodes/...
    env.js
    version.json

When kit.paths.relative is set, this change renders references to the _app/ directory with a leading . so the browser interprets them as relative paths.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented May 22, 2025

⚠️ No Changeset found

Latest commit: 9b9e364

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steamer2k
Copy link
Author

I'll see about following up on tests, lints and changesets tomorrow.

@Pandoks
Copy link

Pandoks commented May 22, 2025

This also allows you to serve the web app through file:// for things like embedded systems, tvs, first class electron support, etc.

Any app where you have direct access to the files and serve start from the index.html without needing to inline your entire app if it's huge.

Pandoks added a commit to Pandoks/sveltronkit that referenced this pull request May 22, 2025
@eltigerchino eltigerchino changed the title Tries to allow the rendering of relative paths feat: allow the rendering of relative paths May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for relative paths of assets when building for static deployments Dynamic basepath
2 participants