fix: keep serialized remote data alive until navigation #14508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows both of these remote function calls...
{#if await condition()} <h1>{await message()}</h1> {/if}...to use the data that was serialized when those queries were encountered during SSR. At present, only
condition()is used, becausestartedbecomestruesynchronously after thehydrate(...)call, before the contents of the if block are rendered.The heuristic here (use the serialized data until navigation occurs) is 98% good enough, though in the long term it would be preferable to knit this stuff into the actual hydration process. That's a ways off though.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits