Skip to content

Conversation

@Rich-Harris
Copy link
Member

This PR allows both of these remote function calls...

{#if await condition()}
  <h1>{await message()}</h1>
{/if}

...to use the data that was serialized when those queries were encountered during SSR. At present, only condition() is used, because started becomes true synchronously after the hydrate(...) call, before the contents of the if block are rendered.

The heuristic here (use the serialized data until navigation occurs) is 98% good enough, though in the long term it would be preferable to knit this stuff into the actual hydration process. That's a ways off though.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2025

🦋 Changeset detected

Latest commit: 0da0b29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one code golf suggestion, otherwise 👍

Rich-Harris and others added 2 commits September 22, 2025 14:48
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@Rich-Harris Rich-Harris marked this pull request as draft September 22, 2025 19:34
@Rich-Harris
Copy link
Member Author

converted this to draft as it doesn't currently handle myquery.refresh(), and while fixing that I uncovered what I think is a bug

@Rich-Harris
Copy link
Member Author

Actually I take it back, not a bug. Just me holding it wrong

@Rich-Harris Rich-Harris marked this pull request as ready for review September 22, 2025 19:42
@Rich-Harris Rich-Harris merged commit 4e1958e into main Sep 22, 2025
22 checks passed
@Rich-Harris Rich-Harris deleted the clear-remote-responses-on-navigate branch September 22, 2025 19:55
@github-actions github-actions bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants