Skip to content

Conversation

@dummdidumm
Copy link
Member

We have to invoke .then eagerly here in order to kick off rendering: it's only starting on access, and await maybe_promise would eagerly access the .then property but call its function only after a tick, which is too late for the paths.reset() below and for any eager getRequestEvent() calls during rendering without AsyncLocalStorage available.

Fixes #14520


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

We have to invoke .then eagerly here in order to kick off rendering: it's only starting on access, and `await maybe_promise` would eagerly access the .then property but call its function only after a tick, which is too late for the paths.reset() below and for any eager getRequestEvent() calls during rendering without AsyncLocalStorage available.

Fixes https://github.com/sveltejs/svelte/issues/16788
@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2025

🦋 Changeset detected

Latest commit: 40ed345

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 7e84789 into main Sep 23, 2025
22 checks passed
@dummdidumm dummdidumm deleted the async-access-render-fix branch September 23, 2025 11:10
@github-actions github-actions bot mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not get the request store (Async SSR bug)

2 participants