Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append trailing slash in manifest #1507

Merged
merged 2 commits into from
May 29, 2021
Merged

Conversation

pzerelles
Copy link
Contributor

@pzerelles pzerelles commented May 20, 2021

Fixes #1486

This will fix #1486 by adding a trailing slash to the pages' path if config.kit.trailingSlash is "always".

@benmccann benmccann added the bug Something isn't working label May 20, 2021
@pzerelles pzerelles changed the title fix: append trailing slash in manifest (#1486) fix: append trailing slash in manifest May 20, 2021
@pzerelles pzerelles force-pushed the bug/1486 branch 2 times, most recently from a6de521 to dd9601e Compare May 22, 2021 08:53
@Rich-Harris Rich-Harris merged commit 1bb44ca into sveltejs:master May 29, 2021
@Rich-Harris
Copy link
Member

thanks 👍

sidharthv96 added a commit to sidharthv96/kit that referenced this pull request May 30, 2021
…r/cutomExtensionTest

* 'master' of https://github.com/sveltejs/kit:
  fix: append trailing slash in manifest (sveltejs#1507)
  Version Packages (next) (sveltejs#1590)
  Rename `handle`'s `render` parameter to `resolve` (sveltejs#1566)
  Replace favicon (sveltejs#1589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid output and infinite redirect loop with adapter-static and trailingSlash: "always"
3 participants