Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Expand list of allowed mime types for binary bodies #1687

Merged
merged 21 commits into from
Jul 12, 2021
Merged

[fix] Expand list of allowed mime types for binary bodies #1687

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f3d5fc9
allow binary bodies with any content type
JeanJPNM Jun 13, 2021
2d30a88
add checks for common binary request bodies
JeanJPNM Jun 20, 2021
3cd030d
add validation for allowed types
JeanJPNM Jun 22, 2021
7c7a25c
Merge branch 'master' into allow-any-binary-content
JeanJPNM Jul 4, 2021
f82abc1
Merge branch 'master' into allow-any-binary-content
JeanJPNM Jul 11, 2021
82ef186
add function to get the body type
JeanJPNM Jul 11, 2021
dc70750
expose utils file to adapters
JeanJPNM Jul 11, 2021
3ec5fdd
replace repeated checks by the utils function
JeanJPNM Jul 11, 2021
1ac70ca
fix import
JeanJPNM Jul 11, 2021
f6e2a24
rename function to `isContentTypeBinary`
JeanJPNM Jul 11, 2021
41c60d8
return a boolean instead of a string enum
JeanJPNM Jul 11, 2021
304e4d3
move function to `adapter-utils.js`
JeanJPNM Jul 11, 2021
27ac1c5
update adapters
JeanJPNM Jul 11, 2021
819ba95
fix issues
JeanJPNM Jul 11, 2021
9e79f75
handle undefined content type
JeanJPNM Jul 11, 2021
6562f17
add changeset
JeanJPNM Jul 11, 2021
949bcb1
small style changes
JeanJPNM Jul 12, 2021
a8b4cbf
Update packages/kit/src/runtime/server/endpoint.js
benmccann Jul 12, 2021
084d26b
Update packages/kit/src/core/adapter-utils.js
benmccann Jul 12, 2021
01414fb
Update packages/kit/src/core/adapter-utils.js
benmccann Jul 12, 2021
e4fac6d
Update packages/kit/src/core/adapter-utils.js
benmccann Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/kit/src/runtime/server/endpoint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ export default async function render_route(request, route) {
if (
typeof body === 'object' &&
!(body instanceof Uint8Array) &&
(!type || type === 'application/json')
(!type || type === 'application/json' || type === 'application/json; charset=utf-8')
Copy link
Contributor Author

@JeanJPNM JeanJPNM Jul 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use type.startsWith('application/json') since the presence (or absence) of the encoding does not change the behavior of the code

) {
headers = { ...headers, 'content-type': 'application/json' };
headers = { ...headers, 'content-type': 'application/json; charset=utf-8' };
normalized_body = JSON.stringify(body);
} else {
normalized_body = /** @type {import('types/hooks').StrictBody} */ (body);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.