-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] preserve user defined config and files on svelte-kit package
#1735
[fix] preserve user defined config and files on svelte-kit package
#1735
Conversation
🦋 Changeset detectedLatest commit: 8f5294f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this generally seems like a good idea to me, but I might leave this open for a little while to see if Rich had any other concerns in mind that I'm not aware of when he wrote it
Aha, I found an exception to Sure, I'm also curious for the reasons behind those specific keys. While we're here, I think the only odd one from the changes listed in the description was the "adds Published npm packages can now "lock" their imports (or |
In #1646 I added logic for adding |
I think it's a good addition for the same reason some authors might not manually specify them. Perhaps only add |
svelte-kit package
svelte-kit package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Could you add a test verifying the new behavior? I recently did set up the infrastructure to test this area.
Added and adjusted the tests to also handle nested files.
Edit: I've added test for file preservation as well, which was one of the main point of this PR. |
Let's first try to get #1747 in and then adjust this one. |
Thanks @dummdidumm 😄, finally got it working now |
I merged #1747, so you can rebase this one now |
* 'master' of github.com:sidharthv96/kit: (1114 commits) Version Packages (next) (sveltejs#1858) Bump vite-plugin-svelte to 1.0.0-next.12 (sveltejs#1869) [fix] preserve user defined config and files on `svelte-kit package` (sveltejs#1735) [fix] handle undefined body on endpoint output (sveltejs#1808) [fix] copy essentials files from root on packaging (sveltejs#1747) [docs] sort config alphabetically (sveltejs#1867) add config.kit.package.emitTypes option (sveltejs#1852) [fix] add $lib alias to js/tsconfig (sveltejs#1860) Pass along custom properties added to Error (sveltejs#1821) Version Packages (next) (sveltejs#1840) Improve grammar in packages FAQ Docs for writing an adapter (sveltejs#1846) Additional documentation around pnpx changeset usage [feat] expose Vite.js `mode` from `$app/env` (sveltejs#1789) Service worker files exclusion support (sveltejs#1645) chore: Enable `vite.server.fs.strict` internally by default (sveltejs#1842) Test with the latest version of Svelte (sveltejs#1848) [docs] don't need to run pnpm install twice Improve HN example docs [fix] correct `ReadOnlyFormData` generator implementation (sveltejs#1837) ...
This PR fixes multiple stuff regarding
package
cli commandREADME.md
filename casing from project root.package.json
and only addsexports
map when it's not defined by the user.exports
map valuesFixes #1734
Fixes #1856