Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vite-plugin-svelte and svelte to fix hmr issue with svelte 3.40 #1992

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

dominikg
Copy link
Member

svelte 3.40.0 introduced a new internal helper insert_hydration that has to be used by svelte-hmr instead of insert.
The fix was released in svelte-hmr 0.14.7, which vite-plugin-svelte 1.0.0-next.14 depends on.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2021

🦋 Changeset detected

Latest commit: 09ea842

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg
Copy link
Member Author

Note svelte version is synced to 3.40 on all packages except for the peer dep of kit and the template in create-svelte to allow using older versions

@benmccann benmccann merged commit 3b293f2 into master Jul 22, 2021
@benmccann benmccann deleted the fix/update-vite-plugin-svelte branch July 22, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants