Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] standardize final output dir as /build (vs /.svelte-kit) #2109

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Aug 5, 2021

Background

We changed the output location to .svelte-kit yesterday because that directory was in the default .gitignore and we had gotten numerous requests that an adapter's output should be ignored without need to take user action. It turned out that standardizing under .svelte-kit has been an unpopular change. Instead we will add build to the default .gitignore alongside .svelte-kit and standardize on writing the final output there with intermediate output going to .svelte-kit

Multi-cloud

For the past 24 hours output has been written in a namespaced manner. The consensus on this seems to be that a more deeply nested output location is a worse experience for the majority of users. Adapters will now be standardized to writing in a non-namespaced manner. If users would like two build with two or more adapters, they can either clear out the build directory between builds or change the default output location using adapter options to set namespaced build directories

Apologies

We're very sorry for the churn this has caused. Changing the output location is a breaking change and breaking changes are a bad user experience, but two breaking changes in a row on the same feature is especially bad. We have added a new "breaking change" label on Github and made it hot pink to stand out. We will label breaking PRs with this in the future and leave them open for a longer comment period to gather more feedback. However, this PR will be merged quickly as we're aiming to get this PR in before too many people update their projects so that most people will be unaffected. For people that updated their projects in the past 24 hours, we're very sorry for the two breaking changes in a row. This will not change again. We've got only a couple dozen open issues left before 1.0 and at that point will be able to follow semver

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2021

🦋 Changeset detected

Latest commit: 1e36e93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member Author

CC adapter maintainers @jthegedus @ryanbethel @sw-yx

@benmccann benmccann merged commit 94b34fa into master Aug 5, 2021
@benmccann benmccann deleted the output-location branch August 5, 2021 15:25
@ryanbethel
Copy link

@benmccann Thanks for the heads up. I will try to update the begin/architect adapter (https://github.com/architect/sveltekit-adapter)probably tomorrow.

@jthegedus
Copy link
Contributor

I'll update the Firebase adapter once this is released.

@benmccann
Copy link
Member Author

it should already be released

@jthegedus
Copy link
Contributor

jthegedus commented Aug 6, 2021

it should already be released

I guess this goes more to my point with #2116 (created before my comment here) as after reading the Changelog of kit I concluded this was not released. I guess because it doesn't actually touch the kit package 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants