Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error #2193

Merged
merged 17 commits into from
Aug 13, 2021
Merged

Handle error #2193

merged 17 commits into from
Aug 13, 2021

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Aug 13, 2021

Closes #1857

#2122 with a few tweaks — updated docs, and reinstated handle_error. Despite the naming similarity, they're separate things — handleError is the user's code, handle_error is what the framework does (which includes calling the user's code). It's better to avoid conflating them, even if the framework isn't doing much beyond what the user does (i.e. just manipulating error.stack)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2021

🦋 Changeset detected

Latest commit: ad10858

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request Aug 13, 2021
5 tasks
@benmccann
Copy link
Member

This PR looks to be accidentally reverting #2178

@Rich-Harris
Copy link
Member Author

yeah, there was a conflict. i was going to tweak it anyway, 'This function runs on every rendering' reads to me like a typo — sorry!

@benmccann
Copy link
Member

looks good to me other than that

just FYI, there was also a highlight that was removed besides the rendering / request wording

handle runs when a page is rendered. If a page is prerendered, handle will not run again when the user requests the page. If you would like to run some functionality on each request, see the documentation for your adapter.

@Rich-Harris Rich-Harris merged commit 0d54ba3 into master Aug 13, 2021
@Rich-Harris Rich-Harris deleted the handle-error branch August 13, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate SSR errors
3 participants