-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle error #2193
Handle error #2193
Conversation
🦋 Changeset detectedLatest commit: ad10858 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR looks to be accidentally reverting #2178 |
yeah, there was a conflict. i was going to tweak it anyway, 'This function runs on every rendering' reads to me like a typo — sorry! |
looks good to me other than that just FYI, there was also a highlight that was removed besides the rendering / request wording
|
Closes #1857
#2122 with a few tweaks — updated docs, and reinstated
handle_error
. Despite the naming similarity, they're separate things —handleError
is the user's code,handle_error
is what the framework does (which includes calling the user's code). It's better to avoid conflating them, even if the framework isn't doing much beyond what the user does (i.e. just manipulatingerror.stack
)Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0