Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] don't decode URL when finding matching route #2354

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Sep 3, 2021

Fixes #1746

Hopefully this is the last of our URL encoding / decoding bugs! I added three more tests to help make sure these cases are covered

@benmccann benmccann added the bug Something isn't working label Sep 3, 2021
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2021

🦋 Changeset detected

Latest commit: 4ed9558

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann force-pushed the url-decoding branch 4 times, most recently from 7f1f779 to 181ddbd Compare September 3, 2021 04:41
@benmccann benmccann merged commit 30a1160 into master Sep 5, 2021
@benmccann benmccann deleted the url-decoding branch September 5, 2021 01:28
@github-actions github-actions bot mentioned this pull request Sep 5, 2021
benmccann added a commit that referenced this pull request Sep 15, 2021
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Sep 19, 2021
* 'master' of https://github.com/sveltejs/kit: (322 commits)
  Version Packages (next) (sveltejs#2438)
  [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435)
  chore: update dependencies (sveltejs#2447)
  [docs] add link to envPrefix option in env var FAQ (sveltejs#2445)
  Fix invalid changeset. Thanks GitHub bot :-p
  [feat] use the Vite server options in dev mode (sveltejs#2232)
  [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437)
  [docs] fix typo (sveltejs#2443)
  [fix] add svelte field when packaging (sveltejs#2431)
  Version Packages (next) (sveltejs#2428)
  [chore] update lockfile
  [fix] update to TS 4.4.3 (sveltejs#2432)
  [chore] add links to repository and homepage to package.json (sveltejs#2425)
  docs: use fragment for prefetching link (sveltejs#2429)
  [fix] encodeURI during prerender (sveltejs#2427)
  Version Packages (next) (sveltejs#2420)
  revert change to versioning during release workflow
  chore: update vite-plugin-svelte (sveltejs#2423)
  [chore] expose Body generic to hook functions (sveltejs#2413)
  [feat] adapter-node entryPoint option (sveltejs#2414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

% cannot be escaped in url params
1 participant