Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] load function should not leak props #2356

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Sep 3, 2021

Fixes #2133.

When navigating from a page with a load() function to a page without a load() function, props were not being reset, so if the second page had a prop with the same name as the prop returned by the first page's load() function, the second page would receive the same prop that the first page did.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

When navigating from a page with a load() function to a page without a
load() function, props were not being reset, so if the second page had a
prop with the same name as the prop returned by the first page's load()
function, the second page would receive the same prop that the first
page did.
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2021

🦋 Changeset detected

Latest commit: eec10d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit debae9a into sveltejs:master Sep 3, 2021
@github-actions github-actions bot mentioned this pull request Sep 3, 2021
@benmccann
Copy link
Member

thank you!!

@rmunn rmunn deleted the fix-leaky-load-props branch September 5, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load function leaks props to other components
3 participants