[breaking] do a single bundling with Vite removing esbuild

[benmccann]

Motivation

The second bundling step is a pain. It leads to a whole class of new bugs where users are now exposed to both all Vite bugs and all esbuild bugs (or sometimes not bugs, but purposely omitted features such as lack of TypeScript reflection). It also makes it substantially more difficult to understand difficult edge cases because you need to learn two build systems.

Description

Removes esbuild from the adapter-node and netlify adapters. Rich suggested that Vercel and Cloudflare require everything to be in a single file, so I've left the esbuild step for those adapters

Related issues

• Fixes Source maps in adapter-node #2517
• Fixes Type reflection issues #798
• Closes ESBuild define option can break adapter-node assetsMiddleware #2581
• May either fix or at least help with Cannot build with .node files and Vercel adapter #1547
• It might fix this bug though we also have another fix out for it: [Sveltekit v next.175+ with Netlify adapter] Cannot find module 'stream/package.json' #2523 (comment)
• I think there were a couple others I forgot as well

Breaking changes

Adapter authors

• Import app via $server-build alias instead of hard-coded relative path
• Need to specify serverEntryPoint
• Simply import @sveltejs/kit/install-fetch directly instead of more complicated shim

Adapter users

• I removed the options for setting environment variable names in adapter-node. Users can create a custom entry point if they'd like to create environment variables with their own naming scheme
• Users of adapter-node's entryPoint option should switch to the new serverEntryPoint option

Open questions

• Do we like the name $server-build for the alias name?
• Is there some way we can allow typing the app for adapter authors? $server-build doesn't seem to be pulling in types at the moment. I'll leave this for another PR since it's not a regression, but it would be nice to think about

[changeset-bot]

🦋 Changeset detected

Latest commit: d6fc153

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@sveltejs/adapter-cloudflare	Patch
@sveltejs/adapter-cloudflare-workers	Patch
@sveltejs/adapter-netlify	Patch
@sveltejs/adapter-node	Patch
@sveltejs/adapter-vercel	Patch
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/svelte/kit/GJZnawTadPuc2Sy8bhuvjzCnEVqP
✅ Preview: https://kit-git-vite-adapter-svelte.vercel.app

[antony]

Just to confirm that I have tested my own app against the netlify adapter here to determine if this fixes the very strange missing transient dependency missing issues that occur when trying to adapt (where some-lib is a transient dependency of an installed package):

> Using @sveltejs/adapter-vercel
 > .svelte-kit/output/server/chunks/__layout-158d2ad5.js:4:7: error: Could not resolve "some-lib"

and can confirm that this PR resolves it.

[tylerbrostrom]

…Cloudflare require[s] everything to be in a single file, so I've left the esbuild step for those adapters.

It should also be possible to remove the esbuild step from adapter-cloudflare and adapter-cloudflare-workers given that JavaScript modules are now supported on Cloudflare Workers (and are the prefered format moving forward).

Granted, this would be a breaking change for adapter-cloudflare-workers, as it uses the older, alternative “service-worker” format.

[Rich-Harris]

closing in favour of #2931