Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] use Netlify's esbuild node_bundler command #2605

Closed
wants to merge 1 commit into from
Closed

[docs] use Netlify's esbuild node_bundler command #2605

wants to merge 1 commit into from

Conversation

brewhousedigital
Copy link

Netlify is trying out a new node_bundler system and you can enable it through the flag 'esbuild'. Without this flag, users may have to install additional packages into their package.json file that don't relate to their project. Using the new node_bundler, you don't need to do this anymore.

Related to this issue:

#1859

Netlify is trying out a new node_bundler system and you can enable it through the flag 'esbuild'. Without this flag, users may have to install additional packages into their package.json file that don't relate to their project. Using the new node_bundler, you don't need to do this anymore.
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2021

⚠️ No Changeset found

Latest commit: ca37110

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

This fixes the issue in the short-term, but I think it's just a workaround for what's really a Netlify bug: netlify/zip-it-and-ship-it#743. They're actively looking at it and if it's going to be fixed in the next couple of days I'd rather not merge a documentation change that I'll have to roll back shortly afterwards

@benmccann benmccann added the documentation Improvements or additions to documentation label Oct 16, 2021
@benmccann benmccann changed the title Added Netlify's esbuild node_bundler command [docs] use Netlify's esbuild node_bundler command Oct 16, 2021
@zvsuperdev
Copy link

@benmccann Going by Netlify's latest comment on that zip-it-and-ship-it issue, it sounds like theyre recommending the above fix until they use esbuild as the default system. If so, would that make this PR useful?

netlify/zip-it-and-ship-it#743 (comment)

@benmccann
Copy link
Member

I'm going to wait and see how that issue plays out. I'll leave this open in the meantime

@benmccann
Copy link
Member

It looks like this will be fixed on the Netlify side, so I'm going to go ahead and close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg:adapter-netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants