Path symmetry

[Rich-Harris]

Forgive the lack of tests, am on a deadline 😬

When you specify a base path but leave assets blank, assets becomes the same as base when you import it...

import { assets } from '$app/paths';

...because of line 10 here:

kit/packages/kit/src/runtime/paths.js

Lines 8 to 11 in 033e076

	export function set_paths(paths) {
	base = paths.base;
	assets = paths.assets || base;
	}

When a load function calls fetch during SSR (or prerendering), assets is stripped from the URL so that static assets can be handled sensibly:

kit/packages/kit/src/runtime/server/page/load_node.js

Line 110 in 033e076

const filename = resolved.replace(options.paths.assets, '').slice(1);

There's an asymmetry here — code like fetch(`${assets}/some-static-data.json`) will cause /xyz/some-static-data.json to be requested, but fetch doesn't know that it needs to strip off the /xyz. This PR fixes that asymmetry.

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

[changeset-bot]

🦋 Changeset detected

Latest commit: d6686a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR