always remove trailing slashes #267
Conversation
| @@ -7,6 +7,17 @@ function md5(body) { | |||
| } | |||
|
|
|||
| export async function render(request, options) { | |||
| if (request.path.endsWith('/') && request.path !== '/') { | |||
There was a problem hiding this comment.
I think in Sapper I believe we're currently avoiding using String#endsWith on the client, which isn't present on certain old browsers, and would require a prototype-modifying polyfill to implement. Are there any goals with Kit about what we want to do about that sort of thing? In this case, could we just use some other simple code instead, especially since it's a string of fixed length 1 we're looking for?
There was a problem hiding this comment.
i think a prototype-modifying polyfill is probably acceptable for something like that. we could always recommend a particular https://polyfill.io/v3/ URL for people to add to their app.html files. (probably best not to automatically inject, because they might need to add their own polyfills). though you've reminded me that the code here only runs on the server, and we would need something equivalent in the client-side router
#192