-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] support etag W/ prefix #2709
Conversation
🦋 Changeset detectedLatest commit: ed8b155 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks — just to clarify, is this something you've encountered? From the MDN docs it seems like Also, mind adding a changeset to the PR so that it causes a version bump? Thank you |
Hi, Richard. Sorry for the delay in reply. I have encountered it while using cloudflare workers. It returns weak etag if request contains "Accept-Encoding: gzip" header(I have not investigated the reason why they do this).
|
Hi, @mkorobkov looks like Nginx converts your Etags into weak ones if you ask it to gzip your content. |
got it. thank you! |
Remove W/ prefix from if-none-match header value before comparing with body hash.
Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0