Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add precompress option to adapter-static #3079

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

sastan
Copy link
Contributor

@sastan sastan commented Dec 20, 2021

This PR adds the precompress option from adapter-node to adapter-static.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2021

🦋 Changeset detected

Latest commit: dc461c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-static Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thank you — I flipped the default to false and updated the readme

@sastan
Copy link
Contributor Author

sastan commented Dec 23, 2021

Thank you

Thank you for this awesome project.

I flipped the default to false and updated the readme

Sorry for that. I'll keep it in mind for the next time.

Have a great holiday...

@frederikhors
Copy link
Contributor

@sastan is there any docs for this feature? Can you add any lines of documentation?

@Rich-Harris
Copy link
Member

@frederikhors https://github.com/sveltejs/kit/tree/master/packages/adapter-static#precompress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants