Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in check_template option #3161

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Add in check_template option #3161

merged 5 commits into from
Jan 4, 2022

Conversation

ghostdevv
Copy link
Member

Currently when using svelte-kit package on it's own it fails due to not finding a app.html, this pr makes the package command skip the check for app.html and makes it default for everything else

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2021

🦋 Changeset detected

Latest commit: dc363ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghostdevv
Copy link
Member Author

ghostdevv commented Dec 31, 2021

I don't think the netlify tests are failing because of this pr

@bluwy bluwy linked an issue Dec 31, 2021 that may be closed by this pull request
@Conduitry
Copy link
Member

This would resolve #2547.

@ghostdevv
Copy link
Member Author

ghostdevv commented Dec 31, 2021

Awesome, I know you mentioned in that issue that you might not want to encourage users to use svelte kit package standalone - for all my other libs I use it all together but for this particular project the documentation makes more sense being in Routify so I want to use svelte kit package essentially standalone @Conduitry

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: dc363ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d4355d18722b0008e78195

@Rich-Harris
Copy link
Member

Thank you! Because of this I realised that we're actually doing the validation at the wrong time — in dev, it's possible to start with a valid template, but then make it invalid without raising an error. What we really need to do is validate it at the point of use. I've added a load_template function that dev and build can both use — that way load_config doesn't need to know anything about template validity.

@Rich-Harris Rich-Harris merged commit 002e7e5 into sveltejs:master Jan 4, 2022
@github-actions github-actions bot mentioned this pull request Jan 4, 2022
@ghostdevv
Copy link
Member Author

Amazing thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte-kit package requires there be an app.html file
4 participants