-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in check_template option #3161
Conversation
🦋 Changeset detectedLatest commit: dc363ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I don't think the netlify tests are failing because of this pr |
This would resolve #2547. |
Awesome, I know you mentioned in that issue that you might not want to encourage users to use svelte kit package standalone - for all my other libs I use it all together but for this particular project the documentation makes more sense being in Routify so I want to use svelte kit package essentially standalone @Conduitry |
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: dc363ee 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d4355d18722b0008e78195 |
Thank you! Because of this I realised that we're actually doing the validation at the wrong time — in dev, it's possible to start with a valid template, but then make it invalid without raising an error. What we really need to do is validate it at the point of use. I've added a |
Amazing thank you |
Currently when using
svelte-kit package
on it's own it fails due to not finding aapp.html
, this pr makes the package command skip the check for app.html and makes it default for everything elsePlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0