Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow prefixes and suffixes around rest parameters #3240

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

Fixes #1714. Not sure why rest segments were ever required to be standalone — probably just me being too lazy to figure out the implementation and not being able to see a valid use case. Since there clearly is a valid use case, and nothing seems to break if we remove that restriction, I finally got around to figuring out the implementation. (Turns out it's not that hard.)

Prefixes probably aren't all that useful, but suffixes (i.e. /tree/[...rest].json.js) certainly are.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2022

🦋 Changeset detected

Latest commit: 0cec51e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 0cec51e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d8cd7db349066d385e38e3

@benmccann
Copy link
Member

I didn't look at the code, but it seems like a fairly safe and desirable change and has tests, so I say ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow rest parameters as end of endpoint route
2 participants