allow prefixes and suffixes around rest parameters #3240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1714. Not sure why rest segments were ever required to be standalone — probably just me being too lazy to figure out the implementation and not being able to see a valid use case. Since there clearly is a valid use case, and nothing seems to break if we remove that restriction, I finally got around to figuring out the implementation. (Turns out it's not that hard.)
Prefixes probably aren't all that useful, but suffixes (i.e.
/tree/[...rest].json.js
) certainly are.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0