Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] urlhash in page store #3273

Merged
merged 4 commits into from
Jan 10, 2022
Merged

[fix] urlhash in page store #3273

merged 4 commits into from
Jan 10, 2022

Conversation

nhe23
Copy link
Contributor

@nhe23 nhe23 commented Jan 10, 2022

Fixes #3205 by setting hash correctly on initial request and updating the store on navigating to a hash url.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2022

🦋 Changeset detected

Latest commit: 053fa3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 10, 2022

❌ Deploy Preview for kit-demo failed.

🔨 Explore the source changes: 053fa3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61dc472db78ccc00073d40a8

@Rich-Harris Rich-Harris merged commit 37d8b87 into sveltejs:master Jan 10, 2022
@Rich-Harris
Copy link
Member

excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent onhashchange detection and hash = "" in $page.url when a hash is present
2 participants