-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crawl prerendered pages without regex hackery #3288
Conversation
✔️ Deploy Preview for kit-demo ready! 🔨 Explore the source changes: 9847466 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61ddcd2709e5710007cf0a8e 😎 Browse the preview: https://deploy-preview-3288--kit-demo.netlify.app |
🦋 Changeset detectedLatest commit: 9847466 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Rich-Harris in |
This is an alternative to #2923. It prevents the sort of bugs that can arise when you're extracting attributes with regex...
...without the overhead of fully parsing the HTML.
parse5
is great, but it's much too large to add on a whim, and does far more than we need. This implementation takes a tiny fraction of the size (it adds less than 100LOC) and is roughly 3x faster (I'm sure someone suitably motivated could make it faster still), which is important in this context.Fixes #2645 and #2742.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0