Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw if url.search or url.searchParams is accessed from page store during prerendering #3314

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 13, 2022

supersedes #2363, closes #2361. Ensures that people don't accidentally grab the query string during prerendering (though they could still get it via url.href or url.toString() if they really want to make life hard for themselves)

  • only creates the url proxy if we're prerendering
  • creates it for the page store as well as the load function

A proper prerendering test suite is still a TODO...

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 47ea3a0

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61df9730057c9d0008b7f98e

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

🦋 Changeset detected

Latest commit: 47ea3a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query accessible from page store during prerendering, but shouldn't be
4 participants