Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add methodOverride to default configs #3411

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

geoffrich
Copy link
Member

Fixes #3385

The svelte.config.js files in the templates were not being used and were overridden by the configs in /shared/+typescript and /shared/-typescript. This PR adds configs for the four cases (outlined below) and makes a note in the template configs that they are overridden.

  • default + typescript: config with methodOverrides
  • default - typescript: config with preprocess and methodOverrides
  • skeleton + typescript: config with preprocess
  • skeleton - typescript: default config

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2022

🦋 Changeset detected

Latest commit: 368bc75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for kit-demo ready!

🔨 Explore the source changes: 368bc75

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e84f2a196a7e00071ea0e7

😎 Browse the preview: https://deploy-preview-3411--kit-demo.netlify.app

@Rich-Harris
Copy link
Member

whoops! good catch

@Rich-Harris Rich-Harris merged commit 48bccdc into sveltejs:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freshly-scaffolded demo app does not include methodOverride in svelte.config.js
2 participants