Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode URIs before checking filename against manifest #3571

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 27, 2022

Fixes #1501fetch('/file with spaces.json') and fetch('/file%20with%20spaces.json') are treated the same way when static/file with spaces.json exists and we're prerendering

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2022

🦋 Changeset detected

Latest commit: 75462d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 75462d2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f2d07dd595510007b581eb

@Rich-Harris Rich-Harris merged commit 27239fa into master Jan 28, 2022
@Rich-Harris Rich-Harris deleted the gh-1501 branch January 28, 2022 15:45
@Mlocik97
Copy link
Contributor

lol, just few days ago I saw PR, where decodeURIComponent was removed from this code.

@benmccann
Copy link
Member

Are you sure? I just jumped back several commits in the git history and don't see it:

const filename = resolved.replace(options.paths.assets, '').slice(1);

Please point at the PR if I'm missing it

@Mlocik97
Copy link
Contributor

oh it was similiar code in other file, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch of URL with space fails during prerendering with npm run build
3 participants