Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shadow endpoint when ending with slash #3740

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Fix shadow endpoint when ending with slash #3740

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d28abad
fix #3718 shadow endpoint fetching if path ends with '/'
PH4NTOMiki Feb 5, 2022
a6caf6e
format and lint
PH4NTOMiki Feb 5, 2022
2d18bfd
added changeset
PH4NTOMiki Feb 5, 2022
7193b60
.
PH4NTOMiki Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-cycles-double.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fixes an error with fetching shadow endpoints if they are ending with '/'
11 changes: 7 additions & 4 deletions packages/kit/src/runtime/client/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,11 +753,14 @@ export class Renderer {
let props = {};

if (has_shadow && i === a.length - 1) {
const res = await fetch(`${url.pathname}/__data.json`, {
headers: {
'x-sveltekit-noredirect': 'true'
const res = await fetch(
`${url.pathname}${url.pathname.endsWith('/') ? '' : '/'}__data.json`,
{
headers: {
'x-sveltekit-noredirect': 'true'
}
}
});
);

if (res.ok) {
const redirect = res.headers.get('x-sveltekit-location');
Expand Down