Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompress wasm files #3790

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Precompress wasm files #3790

merged 4 commits into from
Feb 9, 2022

Conversation

stephtr
Copy link
Contributor

@stephtr stephtr commented Feb 9, 2022

When enabling the precompress option, WebAssembly files currently aren't compressed.
In my case however, compression brings me down from 4 MB to 1.5 MB, which seems to be in line with what can be observed in the wild.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
    just a small change
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
    Test failing is independent of this change.

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

When enabling the `precompress` option, WebAssembly files currently aren't compressed.
In my case however, compression brings me down from 4 MB to 1.5 MB, which seems to be in line with [what can be observed in the wild](https://almanac.httparchive.org/en/2021/webassembly#can-we-improve-compression).
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

🦋 Changeset detected

Latest commit: 0892ad7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-static Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 0892ad7

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6203fffc6df4400008473617

@Rich-Harris Rich-Harris merged commit 225c1ce into sveltejs:master Feb 9, 2022
@Rich-Harris
Copy link
Member

Thank you. Rather than worrying about keeping these in sync, this logic probably belongs in Kit itself — will open a fresh issue for that

@github-actions github-actions bot mentioned this pull request Feb 9, 2022
@stephtr
Copy link
Contributor Author

stephtr commented Feb 9, 2022

Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants