-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precompress wasm files #3790
Precompress wasm files #3790
Conversation
When enabling the `precompress` option, WebAssembly files currently aren't compressed. In my case however, compression brings me down from 4 MB to 1.5 MB, which seems to be in line with [what can be observed in the wild](https://almanac.httparchive.org/en/2021/webassembly#can-we-improve-compression).
🦋 Changeset detectedLatest commit: 0892ad7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 0892ad7 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6203fffc6df4400008473617 |
Thank you. Rather than worrying about keeping these in sync, this logic probably belongs in Kit itself — will open a fresh issue for that |
Thank you too! |
When enabling the
precompress
option, WebAssembly files currently aren't compressed.In my case however, compression brings me down from 4 MB to 1.5 MB, which seems to be in line with what can be observed in the wild.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
just a small change
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Test failing is independent of this change.
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0