-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify escape_json_in_html util #3804
Conversation
🦋 Changeset detectedLatest commit: 44c7e06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 44c7e06 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/62063a2de544bb0007f687e9 |
lgtm. thanks for this! |
I wonder if this would help #3649 too |
followup of #3798
moved JSON.stringify into
escape_json_in_html
and reused it in place of escape_json_value_in_htmlPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0