Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better not found errors #381

Merged
merged 1 commit into from
Feb 10, 2021
Merged

better not found errors #381

merged 1 commit into from
Feb 10, 2021

Conversation

Rich-Harris
Copy link
Member

small quality of life improvement

@Rich-Harris
Copy link
Member Author

cc @FredKSchott maybe the URL should be attached to the error on the Snowpack side? (Would be a breaking change if it resembled this PR of course — I like using error codes instead of error.message for things like NOT_FOUND for this reason. The URL could exist as a separate error.url property though, similar to error.lookups, and then it wouldn't be breaking)

@Rich-Harris Rich-Harris merged commit 474070e into master Feb 10, 2021
@Rich-Harris Rich-Harris deleted the not-found-error branch February 10, 2021 16:01
benmccann pushed a commit that referenced this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants