-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] spelling of .DS_Store #3823
Conversation
🦋 Changeset detectedLatest commit: e32ecc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: e32ecc4 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6205d49514da1b0007549a90 |
Should we just use a case insensitive regex, or is this always |
thanks!
i've never seen it cased any other way (except in our docs, apparently) |
This isn't just changing the docs, it's also changing Kit, so this would need to include a changeset in order to be released. |
OK, I’ve added a changeset. Let me know in case any other adjustments are needed. |
The spelling of
.DS_Store
in the default config is incorrect. As a result,.DS_Store
files are not filtered out from thefiles
array passed to the service worker.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0