Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should fix 4177 navigation to pages with iframe with relative urls are broken #4191

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

PH4NTOMiki
Copy link
Contributor

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #4177
I just did what @Rich-Harris wrote in #4177 (comment) that should fix it.

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2022

🦋 Changeset detected

Latest commit: 7306d28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thanks — can you add a test please?

@PH4NTOMiki
Copy link
Contributor Author

@Rich-Harris But actually I think this PR may make tests more flaky(and that is the reason we did #4070), is there any way to solve this without doing pushState before root.$set?
What does it even do, I don't really understand?

@Rich-Harris
Copy link
Member

Since the DOM update happens in the same turn of the event loop as history.pushState, I don't think this will increase test flakiness — AFAICT Playwright waits until the next tick before resolving waitForNavigation promises. I added a test, and everything is still green (except windows, which is timing out for unrelated reasons), so I think we're good to go

@Rich-Harris Rich-Harris merged commit d34298e into sveltejs:master Mar 4, 2022
@github-actions github-actions bot mentioned this pull request Mar 4, 2022
@PH4NTOMiki PH4NTOMiki deleted the fix-4177 branch March 4, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigation to pages with iframes with relative URLs are broken after #4070
2 participants