Ensure props are loaded from matching endpoint during client-side navigation #4203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4038.
Credit to @aolose for the first version of this (#4139). I tried to work on that branch but things had diverged too much, and I was concerned that the implementation came with fair bit of intrinsic complexity. This implementation is slightly less sophisticated — if an endpoint falls through during client-side navigation, Kit won't find which endpoint actually matches and allow the client to short-circuit the next attempt — but it's less code and easier to follow. Fallthroughs are something of an edge case so I'm okay with them not being fully optimised.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0