Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure props are loaded from matching endpoint during client-side navigation #4203

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Mar 4, 2022

Fixes #4038.

Credit to @aolose for the first version of this (#4139). I tried to work on that branch but things had diverged too much, and I was concerned that the implementation came with fair bit of intrinsic complexity. This implementation is slightly less sophisticated — if an endpoint falls through during client-side navigation, Kit won't find which endpoint actually matches and allow the client to short-circuit the next attempt — but it's less code and easier to follow. Fallthroughs are something of an edge case so I'm okay with them not being fully optimised.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2022

🦋 Changeset detected

Latest commit: b5aa291

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dansvel dansvel mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clashing endpoint-powered pages break route sorting
2 participants