Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround hydration scrolling bug #4221

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Workaround hydration scrolling bug #4221

merged 3 commits into from
Mar 4, 2022

Conversation

Rich-Harris
Copy link
Member

Fixes #4216. Just leaving this here for now — I plan to come back and tidy up the implementation so that it's not using bind:clientHeight at all, but thought it worth showing that moving the element with that binding below the element with the {@html ...} prevents the bug from manifesting.

Ultimately this is something that needs to be fixed in Svelte.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2022

⚠️ No Changeset found

Latest commit: df9651a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris changed the title Gh 4216 Workaround hydration scrolling bug Mar 4, 2022
@Rich-Harris Rich-Harris marked this pull request as ready for review March 4, 2022 22:38
@Rich-Harris Rich-Harris merged commit 95e843e into master Mar 4, 2022
@Rich-Harris Rich-Harris deleted the gh-4216 branch March 4, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling to hash links is broken on Chrome
1 participant