-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adapter-cloudflare-workers prerendering bug [w/ reproduction] #4467
Conversation
🦋 Changeset detectedLatest commit: a5aa190 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
there also seems to be an issue with the resolution of prerendered pages for the i do have it working with some slight change to the manifest generation and by passing in a custom |
fyi, there are more pending changes to adapter-cloudflare-workers. #4276 there has been some discussion about kvAssetHandler in that PR too. |
thanks for pointing me in the direction of the existing work @dominikg. in doing a bit more research, ive found that the current release of the adapter simply does not work correctly for prerendered pages. is there any chance this could be seen as a hotfix that could be released rather than waiting on the migration to Module Workers? |
Hi there!
I noticed a slight discrepancy between
adapter-cloudflare
andadapter-cloudflare-workers
. I need the ability to pass esbuild plugins into the adapter for some issues around running Stripe on cloudflare.Hopefully this small change is OK.edit: In investigating further issues whilst attempting to run
miniflare
against asveltekit build
output, I discovered that there is an error in the wayprerendered files are resolved from the asset KV.
I am unable to complete a
test
run due to an error inadapter-netlify
. I am also unable to complete acheck
due to an error inpackages/kit/test/apps/amp
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0