Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] type check exception handling on form action #4532

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

avarun42
Copy link
Contributor

@avarun42 avarun42 commented Apr 5, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

form.ts in the default demo app currently uses an any type for catching an error thrown during the request. Switch to an unknown type and explicitly check for the correct type before passing to the error function which expects an argument of type Error.

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022

🦋 Changeset detected

Latest commit: 422725d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann changed the title [Demo App] type check exception handling on form action [fix] type check exception handling on form action Apr 11, 2022
@Rich-Harris Rich-Harris merged commit 598c362 into sveltejs:master Apr 14, 2022
@Rich-Harris
Copy link
Member

thanks!

@avarun42 avarun42 deleted the patch-1 branch April 14, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants