DRY things out and tidy up #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Mar 6, 2021
| `); | ||
|
|
||
| write_if_changed(`${output}/service-worker.js`, code); | ||
| // let files = ['service-worker-index.html']; |
There was a problem hiding this comment.
This big block of commented-out code looks suspicious.
There was a problem hiding this comment.
yeah it's not actually called anywhere at the moment, that'll be the focus of #10, which i was hoping to make a start on very soon
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few opportunities to improve the
packages/kitcode while working on #453:@sveltejs/kit/ssr(formerly@sveltejs/kit/renderer)srcfolder — we now havecore,runtime,cli.jsandtypes.d.tssrc/runtimefolder containsclientandserverdirectories (stuff that Kit needs in each of those environments —server/index.jsis the entry point for@sveltejs/kit/ssr), theappdirectory which is exposed in both cases, and a couple of module (paths.jsandload.js) that are needed in both environments but shouldn't be accessible to the developerMuch happier with the state of things now.