Add JSDoc annotations to templates #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16e4945 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
benmccann
reviewed
Apr 14, 2022
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
star2000
reviewed
May 4, 2022
| @@ -1,6 +1,7 @@ | |||
| import { api } from './_api'; | |||
| import type { RequestHandler } from '@sveltejs/kit'; | |||
| import type { RequestHandler } from './index'; | |||
There was a problem hiding this comment.
Why RequestHandler is imported from ./index instead of @sveltejs/kit
There was a problem hiding this comment.
For those sweet sweet generated types
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #4495, adding JSDoc annotations to template source files alongside the TypeScript annotations. These are stripped out of the TypeScript build and the no-typechecking build, while the TypeScript is stripped out of the JSDoc build and the no-typechecking build.