Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update generated tsconfig #4791

Merged
merged 5 commits into from
May 4, 2022
Merged

update generated tsconfig #4791

merged 5 commits into from
May 4, 2022

Conversation

ghostdevv
Copy link
Member

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

It's probably best to discuss the side effects of this change, it fixes my issue of #4460 and also #4764 - However this was changed in #4633 and maybe this change is what should stay and alternative solution to the issues can be done such as what I proposed here #4460 (comment)

@changeset-bot
Copy link

changeset-bot bot commented May 1, 2022

🦋 Changeset detected

Latest commit: 2d3bd52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Maybe we should be using esnext as the target for all of these things? We don't want to output CJS, but we also want to make people opt in to whatever specific degree of JS transpiling they need for their situation.

@ghostdevv
Copy link
Member Author

ghostdevv commented May 1, 2022

Good idea, have switched to that

@Rich-Harris
Copy link
Member

Thanks, this seems like the right fix to me

@Rich-Harris Rich-Harris merged commit b796cb2 into sveltejs:master May 4, 2022
@github-actions github-actions bot mentioned this pull request May 4, 2022
@ghostdevv ghostdevv deleted the fix-package branch May 4, 2022 18:34
@ghostdevv ghostdevv mentioned this pull request May 4, 2022
5 tasks
@oekazuma oekazuma mentioned this pull request May 13, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants