-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move RequestEvent
and ResolveOptions
as public types
#4809
move RequestEvent
and ResolveOptions
as public types
#4809
Conversation
🦋 Changeset detectedLatest commit: a9cc9e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ResolveOptions
and RequestEvent
to public (closes #4805)ResolveOptions
and RequestEvent
to public - fixes #4805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort the changes alphabetically
Sorry about that! Been on vacation. Didn't even think to check for sorting -- I figured that was something the linter handled. Done! |
ResolveOptions
and RequestEvent
to public - fixes #4805RequestEvent
and ResolveOptions
as public types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
thank you! |
#4805 only explicitly requested moving
RequestEvent
toindex.d.ts
, butResolveOptions
is also part ofHandle
's input API, so I moved it too. If, for some reason, we don't want that to be a publicly-accessible type, I'll move it back.Fixes #4805.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0