Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] more specific types for kit.prerender.entries config #4880

Merged
merged 3 commits into from
May 12, 2022
Merged

[feat] more specific types for kit.prerender.entries config #4880

merged 3 commits into from
May 12, 2022

Conversation

HarryAllen1
Copy link
Contributor

@HarryAllen1 HarryAllen1 commented May 12, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

This PR adds stricter typings for config.kit.prerender.entries.
Before, editors won't flag the following as incorrect (but the compiler will):

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		prerender: {
			entries: ['afdasd'],
		},
	},
};

With this PR, the type of entries is stricter, making it easier to debug before building.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2022

🦋 Changeset detected

Latest commit: 62b76f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@HarryAllen1 HarryAllen1 changed the title fix: more reliable typings of config.kit.prerender.entries [feat] more specific types for kit.prerender.entries config May 12, 2022
@Rich-Harris Rich-Harris merged commit e4892d4 into sveltejs:master May 12, 2022
@Rich-Harris
Copy link
Member

Thank you!

@HarryAllen1 HarryAllen1 deleted the patch-1 branch May 12, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants