-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset url
before updating page store
#5039
Conversation
- NavigationResultCache became complicated, so moved it to ./types.ts - If cache ID is the same, check the hash and port for changes. Update the cached URL if nothing but the hash has changed.
🦋 Changeset detectedLatest commit: 03a4ed8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ah whoops, I deleted the 'successfully preloads same route with different hashes many times' test in response to your since-deleted comment @tcc-sejohnson — was that a mistake? |
Nope, all good -- I referenced the wrong lines in the comment and couldn't figure out how to update the reference, so I was just going to re-comment with the correct line references... you were just a bit too fast on the uptake. :) |
@Rich-Harris Quick note: Remember to close #4768 after this is merged -- the issue is no longer linked to the PR. |
Alternative to #4773. We can keep the existing caching logic, we just need to make sure
url
isn't stalePlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0