Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset url before updating page store #5039

Merged
merged 15 commits into from
May 23, 2022
Merged

Reset url before updating page store #5039

merged 15 commits into from
May 23, 2022

Conversation

Rich-Harris
Copy link
Member

Alternative to #4773. We can keep the existing caching logic, we just need to make sure url isn't stale

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2022

🦋 Changeset detected

Latest commit: 03a4ed8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

Rich-Harris commented May 23, 2022

Ah whoops, I deleted the 'successfully preloads same route with different hashes many times' test in response to your since-deleted comment @tcc-sejohnson — was that a mistake?

@elliott-with-the-longest-name-on-github
Copy link
Contributor

@Rich-Harris

Nope, all good -- I referenced the wrong lines in the comment and couldn't figure out how to update the reference, so I was just going to re-comment with the correct line references... you were just a bit too fast on the uptake. :)

@elliott-with-the-longest-name-on-github
Copy link
Contributor

@Rich-Harris Quick note: Remember to close #4768 after this is merged -- the issue is no longer linked to the PR.

@Rich-Harris Rich-Harris merged commit b6c88df into master May 23, 2022
@Rich-Harris Rich-Harris deleted the gh-4768 branch May 23, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sveltekit:prefetch potentially loads a wrong page when an anchor link is involved
2 participants