Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FAQ h1 spacing #5204

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix FAQ h1 spacing #5204

merged 3 commits into from
Jun 21, 2022

Conversation

nimatrengo
Copy link
Contributor

This PR is not important as it is fixing a UX issue on the FAQ page.

Texts were not selectable as the H1 had a negative margin (Not a good practice)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Texts were not selectable as the H1 had negative margin (Not a good practice)
@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2022

⚠️ No Changeset found

Latest commit: b5626fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

This was added in #3717 but I don't know why

@nimatrengo
Copy link
Contributor Author

This was added in #3717 but I don't know why

Not sure too, but it blocks users to select boxes. negative margin will cause impediments to users at any time.

@gtm-nayan
Copy link
Contributor

Last time something like this was there it was a workaround for the headings being covered by the navbar when hash links were used. It was fixed a different way for the docs but the faq page might've been left out.

@benmccann benmccann added the documentation Improvements or additions to documentation label Jun 15, 2022
@nimatrengo
Copy link
Contributor Author

So from your perspective, is it a fix now? rather was it a workaround?

@gtm-nayan
Copy link
Contributor

Looks like the workaround isn't needed anymore, nothing seems to be breaking with your change. Thanks for the fix.


There is another style issue with the FAQ page's code blocks. One liner so probably could include it in this PR and just rename it.

Could you add import '@sveltejs/site-kit/code.css'; to the FAQ page?

@nimatrengo
Copy link
Contributor Author

Looks like the workaround isn't needed anymore, nothing seems to be breaking with your change. Thanks for the fix.

There is another style issue with the FAQ page's code blocks. One liner so probably could include it in this PR and just rename it.

Could you add import '@sveltejs/site-kit/code.css'; to the FAQ page?

CSS file has been added. thanks

@nimatrengo
Copy link
Contributor Author

As I am not familiar with "Kit" and Vercel workflow, not sure why tests have been failed. Vercel - kit-svelte-dev git action is failed too. ⁉️

@gtm-nayan
Copy link
Contributor

Don't worry about the actions, although you have put the import in the wrong file, it should be in routes/faq/index.svelte instead of routes/index.svelte

@nimatrengo
Copy link
Contributor Author

Don't worry about the actions, although you have put the import in the wrong file, it should be in routes/faq/index.svelte instead of routes/index.svelte

Good catch, fixed. ✌️

@Rich-Harris Rich-Harris merged commit adfe94e into sveltejs:master Jun 21, 2022
@Rich-Harris
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants