-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix FAQ h1 spacing #5204
fix FAQ h1 spacing #5204
Conversation
Texts were not selectable as the H1 had negative margin (Not a good practice)
|
This was added in #3717 but I don't know why |
Not sure too, but it blocks users to select boxes. negative margin will cause impediments to users at any time. |
Last time something like this was there it was a workaround for the headings being covered by the navbar when hash links were used. It was fixed a different way for the docs but the faq page might've been left out. |
So from your perspective, is it a fix now? rather was it a workaround? |
Looks like the workaround isn't needed anymore, nothing seems to be breaking with your change. Thanks for the fix. There is another style issue with the FAQ page's code blocks. One liner so probably could include it in this PR and just rename it. Could you add |
CSS file has been added. thanks |
As I am not familiar with "Kit" and Vercel workflow, not sure why tests have been failed. Vercel - kit-svelte-dev git action is failed too. |
Don't worry about the actions, although you have put the import in the wrong file, it should be in routes/faq/index.svelte instead of routes/index.svelte |
Good catch, fixed. ✌️ |
thanks! |
This PR is not important as it is fixing a UX issue on the FAQ page.
Texts were not selectable as the H1 had a negative margin (Not a good practice)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0