Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ability for +page.server.js to respond to GET requests with JSON #6007

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

Rich-Harris
Copy link
Member

Closes #5936. This behaviour is nothing more than a historical accident. It's buggy, and there's no reason to keep it.

If we want routes to serve both HTML and non-HTML, #5896 is a more promising approach.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022

🦋 Changeset detected

Latest commit: 28ae1c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

I wonder if it's worth implementing #5896 as part of this same PR. It looks like you might be able to leave a couple of the tests in place then

@Rich-Harris
Copy link
Member Author

I think we'll want separate tests. I didn't want to do it in this PR because it's probably going to be a chunk of work

.changeset/fresh-pigs-tease.md Outdated Show resolved Hide resolved
Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"parent is not a function" when requesting page endpoint
4 participants