feat: Move `hooks.{js|ts}` init to `Server.init` instead of `Server.respond` #6179

elliott-with-the-longest-name-on-github · 2022-08-23T04:46:14Z

Closes #6147.

Moved initialization of the hooks.js module to Server.init instead of Server.respond.
awaited Server.init in all adapters that use it (adapter-static doesn't).
Added dynamic environment variable support to prerendering. Added tests to verify this support.

TODO:

@Rich-Harris I left you a few letters in the comments of a couple adapters. They're not big deals, just something for you to be aware of and make a judgment on

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

changeset-bot · 2022-08-23T04:46:17Z

🦋 Changeset detected

Latest commit: 5b9b0db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@sveltejs/adapter-cloudflare	Patch
@sveltejs/adapter-cloudflare-workers	Patch
@sveltejs/adapter-netlify	Patch
@sveltejs/adapter-node	Patch
@sveltejs/adapter-vercel	Patch
@sveltejs/kit	Patch
@sveltejs/adapter-auto	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/adapter-netlify/src/serverless.js

packages/adapter-node/src/handler.js

packages/kit/src/vite/build/build_server.js

packages/kit/src/vite/dev/index.js

Rich-Harris

this feels way better. comments inline

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>

Rich-Harris · 2022-08-24T14:25:43Z

Moved the user_hooks = ... code back inside the middleware, because a) it was running before aliases were set up, and b) we need to do it per-request so that changes to src/hooks.js take effect without a server restart

Required since sveltejs/kit#6179, as hooks.js are initialized in server.init()

Required since sveltejs#6179. Closes sveltejs#6308.

As of `1.0.0-next.433` (sveltejs/kit#6179) the build script bundles the app incorrectly. Specifics about the problem: sveltejs/kit#6325

* Run server.init() for edge functions on Vercel. Required since #6179. Closes #6308. * changeset * changes * remove async keyword * Update .changeset/strong-kangaroos-work.md * netlify edge functions * changeset Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>

elliott-with-the-longest-name-on-github added 11 commits August 22, 2022 21:08

feat: Move hooks.js initialization into Server.init

fa53fbb

fix: Server type

02c5764

feat: Await Server.init in adapters

3bfd40c

feat: Await server.init in preview

286648a

fix: Init server during prerender

204acb1

feat: Init hooks when dev mode starts instead of on first request

16cdc7b

fix: Prerendering, but better

f8bd413

feat: Test env vars in prerender

ea9c218

fix: Remove console.log

c6a7f6d

fix: Import in hooks.js of basics test app

7f31360

changeset

3fba16e

vercel bot deployed to Preview – kit August 23, 2022 04:46 View deployment

elliott-with-the-longest-name-on-github requested a review from Rich-Harris August 23, 2022 04:46

vercel bot deployed to Preview – kit-svelte-dev August 23, 2022 04:47 View deployment