-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove getters #6237
remove getters #6237
Conversation
🦋 Changeset detectedLatest commit: cd4bbc8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for one minor detail which could be cleaned up
Closes #6199
Closes #6126
Something we noticed recently is that our use of accessors on
RequestEvent
andLoadEvent
made it difficult to do this sort of thing:On
RequestEvent
, we hadget clientAddress
— this PR changes that togetClientAddress
, which is a breaking change.On
LoadEvent
, we previously hadget url
. But we don't actually need to track whetherurl
was accessed, just whether its properties were accessed (and only the properties that could change during a session — noturl.origin
etc), allowingload
functions to be more conservative about when they re-run.I also noticed we weren't previously tracking
url
access when loading server data, which is now fixed.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0