-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change use:enhance signature to support <button formaction>
#6633
Conversation
🦋 Changeset detectedLatest commit: c8a26fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pushed up a change that should make this work (infering |
Is there any need to access the element if it´s a button? |
This is a good point, we could make that part non-breaking by passing in both |
I just sat down at my laptop to suggest doing exactly that — we are on the same wavelength |
closes #6630. This makes two breaking changes to the
enhance
action:form
is nowelement
, and refers to the element the action was added to. To type that, the function and the SubmissionFunction interface now both take three generic params instead of two.({ element, form, data, result }) => {...}
function instead of just(result) => {...}
. This makes it easier to do things likeuse:enhance={() => whatever}
, wherewhatever
is a function that (for example) callsform.reset()
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0