Fix client-side load error handling #794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's an issue for this, but it's an annoying bug that has been wrecking productivity. Basically, if an error was encountered in a
load
function, any props returned from the root layout'sload
would be unaccounted for when the page hydrates, which triggers thesvelte-hmr
error overlay (which on a separate note, I think we should get rid of, since it should be covered by Vite's own error handling. cc @rixo, though I'll probably add a separate issue for this in due course).This PR mostly amends the client-side logic to mirror the server-side logic, with a couple of other bonus fixes for good measure.